avast / android-styled-dialogs

Backport of Material dialogs with easy-to-use API based on DialogFragment
Apache License 2.0
2.15k stars 450 forks source link

Dialog looks longer #54

Closed yoavst closed 10 years ago

yoavst commented 10 years ago

bug image And for the style of the app - it isn't my design :P

TomasKypta commented 10 years ago

Hi, I looked into the problem but so far I was unable to reproduce it. Could you please post a code snippet (or a gist) that you used to create the dialog?

Also it would be helpful if you could write some info about the device you are seeing the problem on. It might be that the bug only appears on a specific device and/or version of Android. Also none of us knows any hebrew (for all I know), so we would appreciate any help on the bug.

Lastly, I should add that you can always submit a pull request if you manage to solve the problem yourself.

yoavst commented 10 years ago

Ok, I'll research it when I'll have free time.

yoavst commented 10 years ago

I got the same problem in english, happens to me only at 4.4 with the dark theme (Light theme seem to be fine).

davidvavra commented 10 years ago

@yoavst It looks like you didn't apply style like this:

<item name="sdlDialogStyle">@style/DialogStyleLight</item>

Please show us your code snippet.

yoavst commented 10 years ago

So when I apply the light theme it works fine. didn't check what happend if I apply the dark one :/

davidvavra commented 10 years ago

@yoavst Do you apply dark one like this?

<item name="sdlDialogStyle">@style/DialogStyleDark</item>
waylife commented 10 years ago

I got this problem too.Only happens on some machine,such as image image the code is: SimpleDialogFragment.createBuilder(mContext, getSupportFragmentManager()) .setTitle("关于") .setMessage("XXXXXXXXXXXXXXXXXXXXXXXXX") .setPositiveButtonText("确定") .setNegativeButtonText("取消").setRequestCode(42) .setTag("custom-tag") .setCancelable(false).setCancelableOnTouchOutside(false) .show(); I do not use any custom style,only the default dialog style.

waylife commented 10 years ago

Seems I should apply a theme to the activity.So do not get any default style?

davidvavra commented 10 years ago

There is no default style, you always need to select either dark or light style in your application or activity theme. Closing the issue.