search

avast / android-styled-dialogs

Backport of Material dialogs with easy-to-use API based on DialogFragment
Apache License 2.0
2.15k stars 450 forks source link

Added EditTextDialog, ListDialog improvements #89

Closed martinpelant closed 9 years ago

martinpelant commented 9 years ago

Added SINGLE_CHOICE & MULTIPLE_CHOICE options to the listDialog New EditTextDialog

TomasKypta commented 9 years ago

Hi, thank you for your contribution.

Before your pull request can be merged we need to evaluate if the changes are in the desired direction of the library because you are making some bigger changes.

For example EditTextDialogFragment seems to be an unnecessary bloat. You can simply create it easily with SimpleDialogFragment and custom view. And EditText is a bit difficult widget since you usually want to restrict the input in some way. Therefore it doesn't seem to be a good idea to add one to the library.

IEditTextDialogCancelListener seems to be completely unnecessary, there's already ISimpleDialogCancelListener.

Also please fix your code formatting. You are changing indentation of some unchanged code.

davidvavra commented 9 years ago

We have discussed it in the company and we really thank you a lot for multi choice dialog, it solves issue #42

But we don't we don't think many people would use it EditTextDialog - and if they used it, they would need to customize it as well (input types, validations). So please remove EditTextDialog and add it to your app instead. Also we suggest to submit pull requests per feature - creating a large pull request with multiple features complicates things.

You also need to adhere to our code formatting rules. I have uploaded our config file for Android Studio/IDEA here: https://github.com/avast/android-styled-dialogs/blob/master/code-formatting-config.xml If you reformat the code according it, it should be OK.