Dark Theme for dialog box.

avast / android-styled-dialogs

Backport of Material dialogs with easy-to-use API based on DialogFragment

Apache License 2.0

2.15k stars 450 forks source link

Closed ANURAGX closed 9 years ago

ANURAGX commented 9 years ago

New Dark Theme.

Demo activity is changed in order to switch from dark theme to light theme.

screenshot_2015-02-09-00-01-42 screenshot_2015-02-09-00-01-53 screenshot_2015-02-09-00-02-01

davidvavra commented 9 years ago

Hi, I see that you updated the code. Please add a comment when you do, I receive notifications only about comments.

The code looks much better now. Issues:

it still not formatted to our coding style. I noticed that the ifs don't have required number of spaces and sometimes there are no {} brackets
I don't see the useDarkTheme() method in the builder we discussed
Why are you changing ListDialogFragment? I feel that it might be done in cleaner way.

ANURAGX commented 9 years ago

I have formatted the code.

Implemented the useDarkTheme method.

And simplified the listDialogFragment class to some extend.

davidvavra commented 9 years ago

Almost there :)

It looks like you didn't use our code formatting configuration. Can you reformat with our configuration?

ANURAGX commented 9 years ago

I have reformatted the code.

davidvavra commented 9 years ago

It looks like we had some files with bad formatting ourselves :) Thanks for fixing that. Good job and thanks for your contribution!

ANURAGX commented 9 years ago

Its always honour to works for open source project and in return receiving thanks..

Looking forward to work more.