search

avast / continuity

Library for passing context between threads in multi-threaded applications
1 stars 1 forks source link

OpenTracing #2

Open augi opened 6 years ago

augi commented 6 years ago

I don't fully understand the use-case for this library :( Could you please e.g. add to README what is relation to well-known and widely used OpenTracing ? E.g. show an example how to integrate it with OpenTracing, or Zipkin/Jaeger directly. Thanks!

augi commented 6 years ago

Maybe this project is more related to java-concurrent from OpenTracing.

So what about adding support of OpenTracing to this library? It should be almost the same as Mdc*, e.g. look at this implementation on OpenTracing library.

The reason why I'm not preparing a PR is that I'm not sure how to integrate it. Right now, all the Runnables and Callables are wrapped to Mdc. Now, we should wrap it once more, to a new OpenTracingRunnable. But this wrapper cannot be created without an instance of Tracer.