search

avast / pytest-docker

Docker-based integration tests
MIT License
427 stars 71 forks source link

Make container scopes configurable fix solution #103

Closed BetterCallBene closed 10 months ago

BetterCallBene commented 10 months ago

Resolves https://github.com/avast/pytest-docker/issues/89

n1ngu commented 10 months ago

Its sort of stale, but what's the difference with #91 ?

BetterCallBene commented 10 months ago

Its sort of stale, but what's the difference with #91 ?

I agree it is not too much but as the comment https://github.com/avast/pytest-docker/pull/91#discussion_r1409502360 said the mr is not working. I found out the pytest_addoptions is on the wrong place and the mr request was containing a typo and haven‘t any integration tests

BetterCallBene commented 10 months ago

Also, the documentation about this in the Readme.md should be changed. Now it reads

All fixtures have session scope.

A change such as this should be properly documented there.

See https://github.com/avast/pytest-docker/#available-fixtures

I will update the README.md, too.

BetterCallBene commented 10 months ago

Hey @n1ngu, please have look again. Thanks