search

avast / pytest-docker

Docker-based integration tests
MIT License
427 stars 71 forks source link

Add `proto='tcp'` kwarg to `port_for` #32

Closed vicyap closed 10 months ago

vicyap commented 6 years ago

I have a use case where I need to get the udp port for a service.

butla commented 6 years ago

That's a warning, not an error. I think we can live with it for now. We'd need to call the fixtures with one of pytest functions to not invoke that warning. I can't recall that for now, but it's definitely somewhere in the docs related to testing plugins.

Also, putting that range in requirements.in might give the impression that this plugin somehow doesn't support the new pytest.

butla commented 6 years ago

My sample tests (https://github.com/butla/experiments/tree/master/functional_tests) on your branch and the code seems OK.

@vicyap Could you just squash (git rebase -i HEAD~4 while being on the HEAD of your branch) the branch into a single commit?

@AndreLouisCaron Looks good to me, if that matters :)

vicyap commented 6 years ago

Alright, @butla , I squashed my commits

@AndreLouisCaron pending your approval