search

avast / pytest-docker

Docker-based integration tests
MIT License
406 stars 68 forks source link

feat: allow container re-use #67

Closed raddessi closed 2 years ago

raddessi commented 2 years ago

If the spawn and cleanup commands are skipped by overriding the fixture commands to "", None, or False then existing containers can be left around.

Having this as a native feature would be much cleaner than how I'm currently managing this. Thank you for all the work on this project, I've used it in many others with great success :)

raddessi commented 2 years ago

Ugh, I should have looked for PRs earlier, this is a dupe of https://github.com/avast/pytest-docker/pull/64

Luminaar commented 2 years ago

Hello, Thank you for your contribution. I like your PR a bit more that the older one because with your change the command can be skipped entirely. I also appreciate that you updated the readme.

I have a couple of changes I would like to make but I'm unable to push them. I think I need permissions on your fork for that. Could you please grant me those?

Luminaar commented 2 years ago

Closes #63

Luminaar commented 2 years ago

Closes #54

raddessi commented 2 years ago

Sure thing! Im on mobile right now, ill update to allow edits today. Sorry, its been a busy few days i did not see this. Thank you!

raddessi commented 2 years ago

Huh I have this set to allow edits from you. What would you like changed?

Luminaar commented 2 years ago

I'm not able to push to your branch for some reason. Maybe I'm doing something wrong. I've pushed my commits to this branch. If you agree with my changes and will incorporate those commits in the PR, I'll merge it and release a new version.

raddessi commented 2 years ago

Awesome! Im sure its fine, ill get it merged today for you. Thanks!

Luminaar commented 2 years ago

Ping, @raddessi

raddessi commented 2 years ago

Sorry, i see this every day i just havent got time for it. Busy week. I may today