Fixed cleaning of messy output for port number.

avast / pytest-docker

Docker-based integration tests

MIT License

423 stars 71 forks source link

Fixed cleaning of messy output for port number. #81

Open langustav opened 2 years ago

Luminaar commented 2 years ago

Hello, thank you for the PR. Can you please provide more context for this change? For example, you are adding explicit ValueErrors ― what exceptions are raised right now? Should developers handle these exceptions in a special way? Also some tests would be nice.

langustav commented 2 years ago

Sorry, I thought I have linked the issue here. But apparently not. So here it is: https://github.com/avast/pytest-docker/issues/78

wickywaka commented 2 years ago

Any progress on this or any help needed? I came across this issue as well. Simple docker desktop installation on Windows 11

lbenka commented 11 months ago

@Luminaar can I help in order to get this one merged? Have you reviews the attached issues as explainer for the reasoning?

augi commented 8 months ago

I'm not sure this is safe, because the endpoint could IMHO contain something different than an IP address. What about removing weird characters instead?