search

avast / pytest-docker

Docker-based integration tests
MIT License
406 stars 68 forks source link

chore: support the `unix:` scheme in `DOCKER_HOST` #83

Closed JohnVillalovos closed 1 year ago

JohnVillalovos commented 2 years ago

In get_docker_ip(), if DOCKER_HOST is using the unix: scheme then return "127.0.0.1"

PeterBaker0 commented 2 years ago

Would be great to get this merged.

Luminaar commented 2 years ago

Hello and thank you for your contribution. Can you please add a simple test for this condition? I will be happy to merge it

JohnVillalovos commented 1 year ago

Hello and thank you for your contribution. Can you please add a simple test for this condition? I will be happy to merge it

Thanks. Done.

JohnVillalovos commented 1 year ago

@Luminaar Please let me know if there is anything else you need done. Thanks.