search

avast / retdec

RetDec is a retargetable machine-code decompiler based on LLVM.
https://retdec.com/
MIT License
7.97k stars 940 forks source link

Releases should be rebult to allow properly linking #811

Open KOLANICH opened 4 years ago

KOLANICH commented 4 years ago

I have tried to build a radare2 and cutter plugin without rebuilding retdec (rebuilding llvm is clearly inacceptable, in order not to rebuild it, the build system must be fixed) and has failed. The libs have been built without PIC and they cannot be linked. Also the libs have been builtas static, and were linked as static into the binaries. So the binaries are large.

Instead the libs should be built with PIC, and should be shared.

xkubov commented 4 years ago

Hi, right now when you don't want to build radare2/cutter with RetDec you can choose so by providing options to cmake (see README.md). in that case, plugin fetches and statically links required parts of RetDec.

This will however be different in the next release. You are right with one thing and it is that right now RetDec is not built with -fPIC by default and in order for other applications to use RetDec as library building with -fPIC should be default.

KOLANICH commented 4 years ago

This will however be different in the next release.

I don't want to wait the next year for the next release. Could retdec be rebuilt soon? Or maybe can a new release be done out of schedule?

xkubov commented 4 years ago

I meant the release of r2plugin. I think that we can add -fPIC to RetDec's cmake and rebuild releases, what do you think @PeterMatula?