avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

fix: speedup wanna-ml by reducing imports being loaded #117

Closed jsilva closed 3 months ago

jsilva commented 3 months ago

Describe your changes

The wanna-ml cli was slow due to the several google.cloud related imports that happen when it starts. This PR moves several imports to be done only when required, speeding up considerable wanna-ml

Issue ticket number and link

Checklist before requesting a review

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 71.11111% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 74.35%. Comparing base (605b03a) to head (f6087ab).

Files Patch % Lines
src/wanna/cli/plugins/pipeline_plugin.py 0.00% 6 Missing :warning:
src/wanna/cli/plugins/tensorboard_plugin.py 0.00% 3 Missing :warning:
src/wanna/cli/plugins/job_plugin.py 66.66% 2 Missing :warning:
src/wanna/core/services/base.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #117 +/- ## ========================================== - Coverage 74.55% 74.35% -0.21% ========================================== Files 57 57 Lines 2838 2866 +28 ========================================== + Hits 2116 2131 +15 - Misses 722 735 +13 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.