search

avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

fix: ensure call to GCP only happens when cloud build is enabled #125

Closed jsilva closed 3 months ago

jsilva commented 3 months ago

Describe your changes

As we need to be able to build and push containers in an environment without access to GCP Artifact Registry/Cloud Build, the call to get project_number in docker service can only happen when we already know cloud build and GCP access env is allowed.

This PR moves the call to the single function that uses it, instead of the init

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 74.46%. Comparing base (2dc036b) to head (2244019).

Files Patch % Lines
src/wanna/core/services/docker.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #125 +/- ## ========================================== - Coverage 74.50% 74.46% -0.04% ========================================== Files 58 58 Lines 2867 2867 ========================================== - Hits 2136 2135 -1 - Misses 731 732 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.