avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

implemented pipeline parameter sla_seconds -> wanna_sla label #23

Closed JacekHebda closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #23 (31583aa) into master (2bc7718) will decrease coverage by 0.92%. The diff coverage is 30.00%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   74.30%   73.37%   -0.93%     
==========================================
  Files          54       54              
  Lines        2358     2404      +46     
==========================================
+ Hits         1752     1764      +12     
- Misses        606      640      +34     
Impacted Files Coverage Δ
src/wanna/core/services/managed_notebook.py 63.97% <0.00%> (ø)
src/wanna/core/deployment/vertex_pipelines.py 54.54% <22.72%> (-25.46%) :arrow_down:
src/wanna/core/models/pipeline.py 100.00% <100.00%> (ø)
src/wanna/core/services/pipeline.py 91.91% <100.00%> (+0.05%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

JacekHebda commented 1 year ago

Indeed :)

On Wed, 3 Aug 2022 at 14:48, michalmrazek @.***> wrote:

@.**** commented on this pull request.

In samples/pipelines/sklearn/wanna.yaml https://github.com/avast/wanna-ml/pull/23#discussion_r936621285:

@@ -58,3 +58,4 @@ pipelines:

 pipeline_params: params.yaml

 docker_image_ref: ["train", "serve"]

 tensorboard_ref: wanna-sample-pipeline-board
  • sla_seconds: 86400

This should probably also be sla_hours 😉

— Reply to this email directly, view it on GitHub https://github.com/avast/wanna-ml/pull/23#pullrequestreview-1060241109, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZTEZRZ7K3JEC322V4HWIETVXJTBLANCNFSM55IRXXMA . You are receiving this because you authored the thread.Message ID: @.***>

JacekHebda commented 1 year ago

Ready for merge