avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

MLOPS-122 automatic shutdown for user-managed notebooks #31

Closed JacekHebda closed 1 year ago

JacekHebda commented 1 year ago

Two concerns at this point:

  1. threshold for CPU load is hard-coded
  2. Code below: {% for bucket_mount in bucket_mounts %} sudo su -c "mkdir -p {{ bucket_mount["local_path"] }}" sudo su -c "gcsfuse --implicit-dirs {{ ('--only-dir=' ~ bucket_mount["bucket_dir"]) if bucket_mount["bucket_dir"] }} {{ bucket_mount["bucket_name"] }} {{ bucket_mount["local_path"] }}" {% endfor %} was actually failing (iterating over None) even after adding that part: {% if bucket_mount is not none %} ... {% endif %}
codecov-commenter commented 1 year ago

Codecov Report

Base: 72.14% // Head: 72.12% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (0450a92) compared to base (d1f53a7). Patch coverage: 66.66% of modified lines in pull request are covered.

:exclamation: Current head 0450a92 differs from pull request most recent head ad208e5. Consider uploading reports for the commit ad208e5 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #31 +/- ## ========================================== - Coverage 72.14% 72.12% -0.02% ========================================== Files 55 55 Lines 2549 2551 +2 ========================================== + Hits 1839 1840 +1 - Misses 710 711 +1 ``` | [Impacted Files](https://codecov.io/gh/avast/wanna-ml/pull/31?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/deployment/vertex\_pipelines.py](https://codecov.io/gh/avast/wanna-ml/pull/31/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvZGVwbG95bWVudC92ZXJ0ZXhfcGlwZWxpbmVzLnB5) | `55.55% <0.00%> (ø)` | | | [src/wanna/core/services/notebook.py](https://codecov.io/gh/avast/wanna-ml/pull/31/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvbm90ZWJvb2sucHk=) | `59.44% <66.66%> (-0.34%)` | :arrow_down: | | [src/wanna/core/models/notebook.py](https://codecov.io/gh/avast/wanna-ml/pull/31/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvbW9kZWxzL25vdGVib29rLnB5) | `100.00% <100.00%> (ø)` | | | [src/wanna/core/services/managed\_notebook.py](https://codecov.io/gh/avast/wanna-ml/pull/31/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvbWFuYWdlZF9ub3RlYm9vay5weQ==) | `64.78% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.