avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

feat: env variables in notebook models #59

Closed JacekHebda closed 1 year ago

JacekHebda commented 1 year ago

Describe your changes

Issue ticket number and link

Checklist before requesting a review

codecov-commenter commented 1 year ago

Codecov Report

Base: 71.26% // Head: 71.14% // Decreases project coverage by -0.12% :warning:

Coverage data is based on head (63c0030) compared to base (7b90840). Patch coverage: 53.33% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #59 +/- ## ========================================== - Coverage 71.26% 71.14% -0.13% ========================================== Files 55 55 Lines 2631 2644 +13 ========================================== + Hits 1875 1881 +6 - Misses 756 763 +7 ``` | [Impacted Files](https://codecov.io/gh/avast/wanna-ml/pull/59?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/services/managed\_notebook.py](https://codecov.io/gh/avast/wanna-ml/pull/59/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvbWFuYWdlZF9ub3RlYm9vay5weQ==) | `60.00% <16.66%> (-1.94%)` | :arrow_down: | | [src/wanna/core/services/notebook.py](https://codecov.io/gh/avast/wanna-ml/pull/59/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvbm90ZWJvb2sucHk=) | `57.21% <60.00%> (+0.07%)` | :arrow_up: | | [src/wanna/core/models/gcp\_profile.py](https://codecov.io/gh/avast/wanna-ml/pull/59/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvbW9kZWxzL2djcF9wcm9maWxlLnB5) | `100.00% <100.00%> (ø)` | | | [src/wanna/core/models/notebook.py](https://codecov.io/gh/avast/wanna-ml/pull/59/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvbW9kZWxzL25vdGVib29rLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

michalmrazek commented 1 year ago

Nice work, one more idea :) Since you put the env_vars to the gcp_profile, do you thing it would be also good to start using the env vars in training jobs? I checked the python sdk and there should be environment_variables parameter in the run method https://googleapis.dev/python/aiplatform/latest/aiplatform.html#google.cloud.aiplatform.CustomTrainingJob.run 🙏