avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

MLOPS-80 - wanna notebooks build command #7

Closed JacekHebda closed 2 years ago

JacekHebda commented 2 years ago

Currently notebooks allow to create/delete/sync but a wanna user can't successfully just "build/validate" the notebooks

This PR introduces a new command "build" as in wanna notebook build and wanna managed-notebook build that will just parse and validate config for managed-notebooks and parse, validate and build containers configuration and containers for user-managed notebooks.

codecov-commenter commented 2 years ago

Codecov Report

Merging #7 (38086b9) into master (9f05b2a) will increase coverage by 0.63%. The diff coverage is 41.81%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   67.49%   68.12%   +0.63%     
==========================================
  Files          52       52              
  Lines        2298     2328      +30     
==========================================
+ Hits         1551     1586      +35     
+ Misses        747      742       -5     
Impacted Files Coverage Δ
src/wanna/cli/plugins/notebook_plugin.py 0.00% <0.00%> (ø)
src/wanna/core/services/notebook.py 55.43% <50.00%> (+9.39%) :arrow_up:
src/wanna/core/models/notebook.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f05b2a...38086b9. Read the comment docs.