avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

fix: WANNA_DOCKER_BUILD_IN_CLOUD env var override #70

Closed jsilva closed 1 year ago

jsilva commented 1 year ago

Describe your changes

Currently WANNA_DOCKER_BUILD_IN_CLOUD env var when set, independently of the value does not override the yaml config value as per the logic in if self.cloud_build branch

Issue ticket number and link

MLOPS-188

Checklist before requesting a review

codecov-commenter commented 1 year ago

Codecov Report

Base: 73.89% // Head: 73.89% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (e245a0a) compared to base (994781f). Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #70 +/- ## ========================================== - Coverage 73.89% 73.89% -0.01% ========================================== Files 56 56 Lines 2697 2704 +7 ========================================== + Hits 1993 1998 +5 - Misses 704 706 +2 ``` | [Impacted Files](https://codecov.io/gh/avast/wanna-ml/pull/70?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/services/docker.py](https://codecov.io/gh/avast/wanna-ml/pull/70/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvZG9ja2VyLnB5) | `64.15% <75.00%> (+0.24%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.