avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

feat: add support for jinja2-time expressions in pipeline params #80

Closed jsilva closed 1 year ago

jsilva commented 1 year ago

Describe your changes

feat: add support for jinja2-time expressions in pipeline params for flexible dates at pipeline trigger time

Due to https://github.com/python-poetry/poetry/issues/7611 had to fix poetry version to 1.3.2

Issue ticket number and link

MLOPS-260

Checklist before requesting a review

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.04 :warning:

Comparison is base (d767244) 74.15% compared to head (49a529e) 74.11%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #80 +/- ## ========================================== - Coverage 74.15% 74.11% -0.04% ========================================== Files 57 57 Lines 2751 2774 +23 ========================================== + Hits 2040 2056 +16 - Misses 711 718 +7 ``` | [Impacted Files](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/services/base.py](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvYmFzZS5weQ==) | `54.08% <0.00%> (ø)` | | | [src/wanna/core/utils/gcp.py](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvdXRpbHMvZ2NwLnB5) | `56.81% <ø> (ø)` | | | [.../wanna/components/kubeflow/upload\_model\_version.py](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvbXBvbmVudHMva3ViZWZsb3cvdXBsb2FkX21vZGVsX3ZlcnNpb24ucHk=) | `9.52% <14.28%> (-0.74%)` | :arrow_down: | | [...anna/components/kubeflow/get\_or\_create\_endpoint.py](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvbXBvbmVudHMva3ViZWZsb3cvZ2V0X29yX2NyZWF0ZV9lbmRwb2ludC5weQ==) | `13.79% <33.33%> (-0.50%)` | :arrow_down: | | [src/wanna/core/services/pipeline.py](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvcGlwZWxpbmUucHk=) | `91.42% <40.00%> (+0.06%)` | :arrow_up: | | [src/wanna/core/services/jobs.py](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvam9icy5weQ==) | `73.68% <75.00%> (-0.87%)` | :arrow_down: | | [src/wanna/cli/plugins/common\_options.py](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NsaS9wbHVnaW5zL2NvbW1vbl9vcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | | | [src/wanna/core/deployment/models.py](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvZGVwbG95bWVudC9tb2RlbHMucHk=) | `98.01% <100.00%> (ø)` | | | [src/wanna/core/deployment/vertex\_pipelines.py](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvZGVwbG95bWVudC92ZXJ0ZXhfcGlwZWxpbmVzLnB5) | `56.00% <100.00%> (+0.44%)` | :arrow_up: | | [src/wanna/core/models/training\_custom\_job.py](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvbW9kZWxzL3RyYWluaW5nX2N1c3RvbV9qb2IucHk=) | `95.95% <100.00%> (+0.04%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/avast/wanna-ml/pull/80?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.