avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

feat: MLOPS-286 - env option to disable remote GCP validation #82

Closed jsilva closed 1 year ago

jsilva commented 1 year ago

Describe your changes

wanna-ml when loads the yaml runs validations against GCP resources, this is good however for fast iteration it delays the wanna cli runs and this can be frustrating.

This PR provides the option to disable those remote validations that connect GCP.

Issue ticket number and link

MLOPS-286

Checklist before requesting a review

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 48.14% and project coverage change: +0.03 :tada:

Comparison is base (029a53c) 74.03% compared to head (ef4ae27) 74.07%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #82 +/- ## ========================================== + Coverage 74.03% 74.07% +0.03% ========================================== Files 57 57 Lines 2777 2785 +8 ========================================== + Hits 2056 2063 +7 - Misses 721 722 +1 ``` | [Impacted Files](https://codecov.io/gh/avast/wanna-ml/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/utils/validators.py](https://codecov.io/gh/avast/wanna-ml/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvdXRpbHMvdmFsaWRhdG9ycy5weQ==) | `67.41% <12.50%> (-0.77%)` | :arrow_down: | | [src/wanna/core/utils/env.py](https://codecov.io/gh/avast/wanna-ml/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvdXRpbHMvZW52LnB5) | `100.00% <100.00%> (ø)` | | | [src/wanna/core/utils/gcp.py](https://codecov.io/gh/avast/wanna-ml/pull/82?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvdXRpbHMvZ2NwLnB5) | `56.81% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.