avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

feat: MLOPS-287 - allow setting Vertex AI Experiment name in wanna pipelines #83

Closed jsilva closed 1 year ago

jsilva commented 1 year ago

Describe your changes

In Vertex AI we can set the Experiment name of a PipelineJob submit, however it can't be the same as the pipeline name itself as it can clash with different resource in the metastore.

Issue ticket number and link

MLOPS-287

Checklist before requesting a review

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 :tada:

Comparison is base (f8e0a0b) 74.07% compared to head (78aea38) 74.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #83 +/- ## ========================================== + Coverage 74.07% 74.16% +0.09% ========================================== Files 57 57 Lines 2785 2795 +10 ========================================== + Hits 2063 2073 +10 Misses 722 722 ``` | [Impacted Files](https://codecov.io/gh/avast/wanna-ml/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/services/pipeline.py](https://codecov.io/gh/avast/wanna-ml/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvcGlwZWxpbmUucHk=) | `89.51% <ø> (ø)` | | | [src/wanna/core/deployment/models.py](https://codecov.io/gh/avast/wanna-ml/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvZGVwbG95bWVudC9tb2RlbHMucHk=) | `98.03% <100.00%> (+0.01%)` | :arrow_up: | | [src/wanna/core/deployment/vertex\_pipelines.py](https://codecov.io/gh/avast/wanna-ml/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvZGVwbG95bWVudC92ZXJ0ZXhfcGlwZWxpbmVzLnB5) | `56.43% <100.00%> (+0.43%)` | :arrow_up: | | [src/wanna/core/models/pipeline.py](https://codecov.io/gh/avast/wanna-ml/pull/83?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvbW9kZWxzL3BpcGVsaW5lLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.