avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

fix: ensure builds don't timeout due to gcp client pooling #87

Closed jsilva closed 1 year ago

jsilva commented 1 year ago

Describe your changes

Often happen the when building large GPU images on cloud build we hit GCPs client pooling timeout, and the cloud build timeout itself does not affect this setting.

This change ensures the config cloud build timeout, also applies to the pooling

Issue ticket number and link

Checklist before requesting a review

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.02 :warning:

Comparison is base (8b9d240) 74.16% compared to head (c963c49) 74.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #87 +/- ## ========================================== - Coverage 74.16% 74.15% -0.02% ========================================== Files 57 57 Lines 2795 2797 +2 ========================================== + Hits 2073 2074 +1 - Misses 722 723 +1 ``` | [Impacted Files](https://codecov.io/gh/avast/wanna-ml/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/services/docker.py](https://codecov.io/gh/avast/wanna-ml/pull/87?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvZG9ja2VyLnB5) | `64.62% <25.00%> (-0.14%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.