avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

fix: handle windows paths gracefully #88

Closed jsilva closed 1 year ago

jsilva commented 1 year ago

Describe your changes

Solve a bug for windows users when using cloud build feature where the uploaded tar gets incorrect paths and error out on Fetching storage object: gs://some-bucket/build%5Cdocker%5Cserve.tar.gz#1681392101778679

Issue ticket number and link

Checklist before requesting a review

codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (8b9d240) 74.16% compared to head (60c1b2f) 74.16%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #88 +/- ## ======================================= Coverage 74.16% 74.16% ======================================= Files 57 57 Lines 2795 2795 ======================================= Hits 2073 2073 Misses 722 722 ``` | [Impacted Files](https://codecov.io/gh/avast/wanna-ml/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/services/docker.py](https://codecov.io/gh/avast/wanna-ml/pull/88?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvZG9ja2VyLnB5) | `64.76% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.