avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

feat: better .ignore parsing for local docker build cache #89

Closed jsilva closed 1 year ago

jsilva commented 1 year ago

Describe your changes

Issue ticket number and link

MLOPS-299

Checklist before requesting a review

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 71.42% and project coverage change: +0.07 :tada:

Comparison is base (8b9d240) 74.16% compared to head (2804939) 74.24%.

:exclamation: Current head 2804939 differs from pull request most recent head 1e3141f. Consider uploading reports for the commit 1e3141f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #89 +/- ## ========================================== + Coverage 74.16% 74.24% +0.07% ========================================== Files 57 57 Lines 2795 2803 +8 ========================================== + Hits 2073 2081 +8 Misses 722 722 ``` | [Impacted Files](https://codecov.io/gh/avast/wanna-ml/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/services/jobs.py](https://codecov.io/gh/avast/wanna-ml/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvam9icy5weQ==) | `73.68% <0.00%> (ø)` | | | [src/wanna/core/services/notebook.py](https://codecov.io/gh/avast/wanna-ml/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvbm90ZWJvb2sucHk=) | `56.93% <0.00%> (ø)` | | | [src/wanna/core/services/pipeline.py](https://codecov.io/gh/avast/wanna-ml/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvcGlwZWxpbmUucHk=) | `89.51% <ø> (ø)` | | | [src/wanna/core/services/docker.py](https://codecov.io/gh/avast/wanna-ml/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvZG9ja2VyLnB5) | `64.76% <46.15%> (ø)` | | | [src/wanna/core/deployment/vertex\_pipelines.py](https://codecov.io/gh/avast/wanna-ml/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvZGVwbG95bWVudC92ZXJ0ZXhfcGlwZWxpbmVzLnB5) | `56.86% <50.00%> (+0.42%)` | :arrow_up: | | [src/wanna/core/deployment/models.py](https://codecov.io/gh/avast/wanna-ml/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvZGVwbG95bWVudC9tb2RlbHMucHk=) | `98.03% <100.00%> (ø)` | | | [src/wanna/core/models/gcp\_components.py](https://codecov.io/gh/avast/wanna-ml/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvbW9kZWxzL2djcF9jb21wb25lbnRzLnB5) | `95.00% <100.00%> (ø)` | | | [src/wanna/core/models/notebook.py](https://codecov.io/gh/avast/wanna-ml/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvbW9kZWxzL25vdGVib29rLnB5) | `100.00% <100.00%> (ø)` | | | [src/wanna/core/services/path\_utils.py](https://codecov.io/gh/avast/wanna-ml/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvcGF0aF91dGlscy5weQ==) | `100.00% <100.00%> (ø)` | | | [src/wanna/core/utils/env.py](https://codecov.io/gh/avast/wanna-ml/pull/89?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvdXRpbHMvZW52LnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.