avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
18 stars 3 forks source link

feat: Add the option to load and compile a kubeflow pipeline via a python import path #90

Closed jsilva closed 1 year ago

jsilva commented 1 year ago

Describe your changes

Currently wanna expects a path to a python file and uses compile_pyfile to compile the kip pipeline.

This has the limitation of where the pipeline file can exists and what can be imported due to python path

Issue ticket number and link

MLOPS-301

Checklist before requesting a review

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 68.18% and project coverage change: -0.04 :warning:

Comparison is base (fab1332) 74.24% compared to head (d5078f8) 74.20%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #90 +/- ## ========================================== - Coverage 74.24% 74.20% -0.04% ========================================== Files 57 57 Lines 2803 2822 +19 ========================================== + Hits 2081 2094 +13 - Misses 722 728 +6 ``` | [Impacted Files](https://codecov.io/gh/avast/wanna-ml/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/utils/credentials.py](https://codecov.io/gh/avast/wanna-ml/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvdXRpbHMvY3JlZGVudGlhbHMucHk=) | `64.51% <0.00%> (ø)` | | | [src/wanna/core/services/pipeline.py](https://codecov.io/gh/avast/wanna-ml/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvc2VydmljZXMvcGlwZWxpbmUucHk=) | `87.09% <61.53%> (-2.42%)` | :arrow_down: | | [src/wanna/core/models/pipeline.py](https://codecov.io/gh/avast/wanna-ml/pull/90?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvbW9kZWxzL3BpcGVsaW5lLnB5) | `96.96% <87.50%> (-3.04%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.