avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

fix: scheduler deployment not updating #93

Closed jsilva closed 1 year ago

jsilva commented 1 year ago

Describe your changes

Fixes a bug on the wanna deployment not updating cloud scheduler config

Issue ticket number and link

MLOPS-317

Checklist before requesting a review

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6ffbb4b) 74.18% compared to head (cfa26d1) 74.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #93 +/- ## ======================================= Coverage 74.18% 74.18% ======================================= Files 57 57 Lines 2824 2824 ======================================= Hits 2095 2095 Misses 729 729 ``` | [Impacted Files](https://app.codecov.io/gh/avast/wanna-ml/pull/93?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/deployment/vertex\_scheduling.py](https://app.codecov.io/gh/avast/wanna-ml/pull/93?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvZGVwbG95bWVudC92ZXJ0ZXhfc2NoZWR1bGluZy5weQ==) | `91.30% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.