avast / wanna-ml

Complete MLOps framework for Vertex-AI
MIT License
17 stars 3 forks source link

fix: WANNA_GCP_ENABLE_REMOTE_VALIDATION logic #98

Closed racinmat closed 10 months ago

racinmat commented 11 months ago

Describe your changes

fixes #97 but we can talk about the fix and maybe we should invert the logic of the disabling while keeping the name of the environment variable?

Issue ticket number and link

Checklist before requesting a review

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (897aaad) 74.42% compared to head (00a4d6f) 74.42%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #98 +/- ## ======================================= Coverage 74.42% 74.42% ======================================= Files 57 57 Lines 2839 2839 ======================================= Hits 2113 2113 Misses 726 726 ``` | [Files Changed](https://app.codecov.io/gh/avast/wanna-ml/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast) | Coverage Δ | | |---|---|---| | [src/wanna/core/utils/env.py](https://app.codecov.io/gh/avast/wanna-ml/pull/98?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=avast#diff-c3JjL3dhbm5hL2NvcmUvdXRpbHMvZW52LnB5) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.