search

avatartwo / avatar2

Python core of avatar²
Apache License 2.0
518 stars 98 forks source link

Installer has invalid references to GitHub repos #106

Open peterrakolcza opened 2 years ago

peterrakolcza commented 2 years ago

Hey!

I have found several invalid references to GitHub repos while I was trying to install avatar2.

When I try to run python -m avatar2.installer, most targets, that are available from the package manager, install without a problem, however, others exited when the installer had tried to clone the given repos.

After debugging a little, I found out that branches for the targets' repos have been changed!

mariusmue commented 2 years ago

Hi!

Thanks for reporting! Indeed, we have changed our development over to docker, and rarely use the installer these days. I see two ways forward: 1) fixing the references and bringing the installer up to date 2) Deprecating the installer and be more detailed about our dockerized setup

Personally, I would prefer (2), I think - unless someone wants to take over the installer feature. @rawsample what is your opinion?

rawsample commented 2 years ago

Hello,

I agree with you, the docker approach is more robust and should be prioritize for targets installation. We can deprecate the installer. Nevertheless, bringing it up to date was not a huge effort. I will commit this soon.