search

avatartwo / avatar2

Python core of avatar²
Apache License 2.0
525 stars 100 forks source link

Inception debugger #52

Closed rawsample closed 4 years ago

rawsample commented 4 years ago
mariusmue commented 4 years ago

This PR looks great, thanks @rawsample! I especially enjoy the presence of testcases and some documentation. That being said, would you mind integrating the following improvements? Afterwards, there shouldn't be any roadblocks for a merge. :)

1) modify avatar2's .travis.yml, so that test_inceptionprotocol.py is executed by our CI (and succeeds) 2) Extend the documentation of the InceptionTarget class, briefly describing what Inception is, and where to find the paper/hardware? A stripped down version of tests/inception/README.md would do. 3) the processor-string 'cortexM3' does not match any official writing for M3 boards. I would suggest renaming it to: cortex-m3 or Cortex-M3, with slight preference on the first one.

Thanks again!

mariusmue commented 4 years ago

Thanks for the update. It looks like the CI fails due to missing requirements? Can you add them to avatar2's setup.py?

Here is the url for the CI-run: https://travis-ci.org/github/avatartwo/avatar2/builds/674018331

mariusmue commented 4 years ago

And merged! thanks :)