New MIPS architecture - Githubissues

avatartwo / avatar2

Python core of avatar²

Apache License 2.0

525 stars 100 forks source link

New MIPS architecture #71

Closed rawsample closed 3 years ago

mariusmue commented 3 years ago

This mips.py is missing a couple of definitions as present for the other files, like keystone_arch, get_x_executable, and so on. Hence, it likely breaks plugins and similar when merged into main as-is. I recommend looking at arm.py and defining the according arch-dependent variables.

rawsample commented 3 years ago

I think you didn't check the right commit, the definitions are added on 88cc95893617dd7abd7634b3ab6e51184341cd50 In addition, I just push unicorn definition.

mariusmue commented 3 years ago

Looks great to me, especially the testcases and GDB_MULTI resolving! :)