search

avatartwo / avatar2

Python core of avatar²
Apache License 2.0
518 stars 98 forks source link

Fixed version checking for pygdbmi #95

Closed jcnauta closed 2 years ago

jcnauta commented 2 years ago

Version checking for pygdbmi should be for the pygdbmi version, not the Python version. If it tries to use the wrong pygdbmi-version (which has breaking changes) the shutdown method also throws an exception for me. I have fixed this as well.

mariusmue commented 2 years ago

Hi @jcnauta. Thank you for the pull request! From my side, it looks all good. @rawsample will verify that it integrates without errors in our CI, and then your fix will be included in the upcoming v1.4.7 of avatar2.

rawsample commented 2 years ago

Thanks @jcnauta !