avats-dev / motivate

:zap: motivate :zap: - A simple script to print random motivational quotes. Highly influenced by linux command fortune.
MIT License
24 stars 107 forks source link

Add New Random Inspirational Quotes #75

Closed AdnanMuhib closed 3 years ago

AdnanMuhib commented 3 years ago

Check one of the below boxes as per your PR

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

I'm happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged !

Thanks!

welcome[bot] commented 3 years ago

Thanks for opening this pull request!
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄 welcome

AdnanMuhib commented 3 years ago

@avats-dev Renamed the file.

avats-dev commented 3 years ago

@AdnanMuhib you also need to change the order. quote should come first and then its author. See other contributions for reference. Thanks

AdnanMuhib commented 3 years ago

done 🚀 however, it really doesn't matter in which order JSON keys are when parsing. I agree that order should be the same as others if we think about consistency.

avats-dev commented 3 years ago

Yeah @AdnanMuhib , it doesn't matters but consistency and order matters. Thanks for your contribution :tada:

welcome[bot] commented 3 years ago

Congrats on merging your first pull request! 🙌🎉⚡️ cheers Now that you've completed this, you can help someone else take their first step!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

Try looking at this list of [add more quotes](https://github.com/avats-dev/motivate/issues/1) issue, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉