search

avc975711 / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

HTML #1

Open abb1991 opened 7 years ago

abb1991 commented 7 years ago

Your HTML looks solid. I like your use of divs, but you should consider extending them so they that one div encapsulates a given section of code. Also consider indenting your code for readability, so:

<div id="Frames"><h2>Frames</h2></div>
  <img src="./resources/frames.jpeg">
      <h3>Art Frames (assorted)</h3>
        <p>Assorted frames made of different material, including MDF,
          birchwood, and PDE. Select frames can be painted according to
          your needs. <div id="Price">Starting at $2.00 / frame.</div>
        </p>

should be

<div id="Frames"><h2>Frames</h2>
  <img src="./resources/frames.jpeg">
  <h3>Art Frames (assorted)</h3>
  <p>Assorted frames made of different material, including MDF,
    birchwood, and PDE. Select frames can be painted according to
    your needs. <span id="Price">Starting at $2.00 / frame.</span>
  </p>
</div>
avc975711 commented 7 years ago

I believe I've fixed the indenting. However, I can't extend the divs because then the css styling will apply the green background to the image an the paragraph.