avcopan / Reaction-Model-Electronic-Structure-Schema

A repository for drafting a schema for reaction model electronic structure data
MIT License
0 stars 0 forks source link

Separating "Point" from "Calculation" #1

Open avcopan opened 1 week ago

avcopan commented 1 week ago

I raised a question here about whether the identification of a "Point" (i.e. molecular geometry) should be separated from the description of a particular "Calculation" (i.e. program and input file, specifying how a set of results were calculated).

The motivation for this separation would be that it is fairly common to run multiple calculations (possibly with multiple different programs) on the same structure. For example:

Each point could be associated with multiple calculations.

So, we would have something like:

Calculation -> Point -> Conformer -> Species -> Lumped Species -> Node/Stage -> Edge/Step

flrnslbch commented 3 hours ago

I think that separating a point from calculations is definetly worth it. We may even be able to find a canonical form of a point based on its connectivity, stereocenters, etc. by using InChIs and co (or our own idenitifers). This would greatly simplify automation across different datasets using this canonical represenation.

Regarding the connection of a species and point via only a conformer, I will create a separate issue/PR.