avdbrink / VSTS-SSAS-Extension

VSTS tasks for building and deploying SSAS projects
MIT License
6 stars 7 forks source link

SSAS Build task: Can't handle spaces in path or file name to project file #11

Open FranzKohl opened 2 years ago

FranzKohl commented 2 years ago

We have a SSAS projects where the developers unfortunately used spaces in both the path and the filename, and due to circumstances out of my reach, they cannot change it...

However, this leads to the SSAS Build task to fail, because the $ArgumentList you're providing to Start-Process inside BuildSSASTask.ps1 cannot handle this.

The fix in BuildSSASTask.ps1 is as simple as to surround the variable $projPath in the string assigned to $ArgumentList with escaped quotes - please see the attached image file for the exact fix (I used an image here because I did not find a way in markup to mask the tick sign not to be interpreted as quote signal...): 2022-01-10 20_10_11-Window

@avdbrink It would simply be great if you could fix this and provide an updated version of your task to the marketplace - I'd highly appreciate it!

Best regards, Franz Kohl

FranzKohl commented 2 years ago

@avdbrink - I've fixed this issue in my fork, tested it in my own Azure DevOps Server 2020.1 environment, and created a pull request (Fix: correct handling of spaces in path or filename of project file #12) to enable you to more easily get this fix into your extension.

I didn't touch the version information in vss-extension.json & BuildSSASTask\task.json, so this is up to you. In my tests I built the extension using version 1.0.8, so if you implement the fix (and change probably more) and publish it to the marketplace it would be nice if you could increase the version to at least 1.0.9 to re-enable auto-updates in my environment.

Thanks for taking care in advance & best regards, Franz