avdept / JellyBoxPlayer

Native desktop and mobile music client for Jellyfin
https://apps.apple.com/us/app/jellybox-player/id6469732117
GNU Affero General Public License v3.0
340 stars 10 forks source link

ci(build): Add Build And Release Pipeline #83

Open Thogsit opened 2 months ago

Thogsit commented 2 months ago

Hint: This PR is built upon #80 and as such has an unclean diff

Goal

This PR contains a new workflow file that has build jobs for the 3 major OSs Linux, Windows and MacOS. Each build results gets uploaded and published in a new release with the branches' name.

TODOs (can also be adressed via later PRs)

EDIT: Tried on native Windows, music doesn't work as with Wine on Linux. I'll work on it. Also, on Windows no Minimize/Maximize/Close buttons exist and the window is not movable via dragging; I'll try out the same migration from window_manager to the bitsdojo one which should fix that.

avdept commented 1 month ago

Hey, thanks for making this, big work!

I'm away these days, will check once get fully back

avdept commented 1 month ago

@Thogsit Btw for linux - does it packs with lib_mpv or that should be installed separately?

Thogsit commented 1 month ago

@Thogsit Btw for linux - does it packs with lib_mpv or that should be installed separately?

Good point, I've got mpv installed on my machine so everything works, but for the Pipeline I had to explicitly install mpv with apt; I should check out if and how it is required for the manual Linux build. Tracked with #86

I'm away for work this week, so won't check back on this until next week :)

avdept commented 1 month ago

@Thogsit Btw for linux - does it packs with lib_mpv or that should be installed separately?

Good point, I've got mpv installed on my machine so everything works, but for the Pipeline I had to explicitly install mpv with apt; I should check out if and how it is required for the manual Linux build. Tracked with #86

I'm away for work this week, so won't check back on this until next week :)

Sorry, been away as well. Ill check PR over weekends

Thogsit commented 1 month ago

Finally I'm back from vacation and took a look at it again :).

I've now added information to the main README regarding Linux and Windows. Also, I added Android to the CI, so that on every push to main the Release section is automatically updated with a new version of the Android, Linux and Windows builds.

This should make this PR as far as I'm concerned ready for merging :+1:.

avdept commented 3 weeks ago

Finally I'm back from vacation and took a look at it again :).

I've now added information to the main README regarding Linux and Windows. Also, I added Android to the CI, so that on every push to main the Release section is automatically updated with a new version of the Android, Linux and Windows builds.

This should make this PR as far as I'm concerned ready for merging 👍.

Hey, welcome back!

And thanks for your work. I'll have a bit of time over weekends to check and merge it!