avdi / hammertime

Exception debugging console for Ruby
MIT License
208 stars 10 forks source link

Does not support 1.9.2 #1

Open pivotaldinamundo opened 13 years ago

pivotaldinamundo commented 13 years ago

We tried to bundle with the hammertime gem under 1.9.2-p180 and got the following:

Installing rbx-require-relative (0.0.5) /Users/pivotal/.rvm/rubies/ruby-1.9.2-p180/lib/ruby/site_ruby/1.9.1/rubygems/installer.rb:388:in `ensure_required_ruby_version_met': rbx-require-relative requires Ruby version ~> 1.8.7. (Gem::InstallError)

Sadly, it looks like there is a dependency on 1.8.7 :(

Kevin & Daniela Pivotal Labs, Inc.

naquad commented 13 years ago

thats the last problem. just put the actual lib into separate file and require it (don't forget to install highline), but it won't work either. internals in ruby 1.9.2 changed and raise can't be overriden easily.

pagojo commented 12 years ago

Actually it has nothing to do really with Ruby 1.9.2 raise internals. If interested have a look at https://github.com/avdi/hammertime/pull/2

Hopefully Avdi will like it :-)

naquad commented 12 years ago

i've took a look and i didn't see the fix for the issue. what i've meant is that C modules will still raise usual exceptions.

pagojo commented 12 years ago

Daniel, our fix deals as it describes with the problem of Hammertime 0.0.2 not handling Ruby exceptions such as LoadError inside the hammertime_raise which was the cause for breakage when attempting to run it on 1.9.x.

The issue with Hammertime not dealing with C exceptions in general remains, but this was never a problem in porting Hammertime to Ruby 1.9.2. Our fix makes Hammertime run on 1.9.x and covers some other corner cases as well.

paradisaeidae commented 9 years ago

Cannot install with Ruby 2.2.2.... Using pry until can... no big deal. gem install hammertime [11:31] Fetching: columnize-0.9.0.gem (100%) Successfully installed columnize-0.9.0 Fetching: rbx-require-relative-0.0.9.gem (100%) Successfully installed rbx-require-relative-0.0.9 Fetching: linecache-0.46.gem (100%) Building native extensions. This could take a while... ERROR: Error installing hammertime: ERROR: Failed to build gem native extension.

//RUBY/2.2.2/bin/ruby-2.2.2 -r ./siteconf20150824-29036-xvrnpy.rb extconf.rb

Can't handle 1.9.x yet * extconf.rb failed * Could not create Makefile due to some reason, probably lack of necessary libraries and/or headers. Check the mkmf.log file for more details. You may need configuration options.

Provided configuration options: --with-opt-dir --without-opt-dir --with-opt-include --without-opt-include=${opt-dir}/include --with-opt-lib --without-opt-lib=${opt-dir}/lib --with-make-prog --without-make-prog --srcdir=. --curdir --ruby=//RUBY/2.2.2/bin/$(RUBY_BASE_NAME)-2.2.2

extconf failed, exit code 1

cheerfulstoic commented 9 years ago

Getting this as well, did you find a solution @paradisaeidae ?

paradisaeidae commented 9 years ago

Hi Cheerful, Zoop, nope. Still using pry. I know hammertime would be better, just cannot remember why.

cheerfulstoic commented 9 years ago

Thanks ;)

I was hoping to use hammertime because it automatically captures exceptions in any process and lets you go into an irb session. I was running a rake task and I didn't want to have to go to the bother of drilling down to where the error was happening and putting in a pry