Refactor to move more builder methods out into Command classes

avdi / naught

A toolkit for building Null Object classes in Ruby

MIT License

1.05k stars 53 forks source link

Refactor to move more builder methods out into Command classes #34

Closed samnang closed 11 years ago

samnang commented 11 years ago

See #11

I have moved all of builder's methods into commands except black_hole because it's so simple 1 line, so that's why I'm not sure it worths to move it or not?

coveralls commented 11 years ago

Coverage remained the same when pulling 25990b3c44cba1aa005ebeffa20ad51fc38ab2cf on samnang:move_builder_methods_into_commands into 0869d4a8d4b304ae18e68789d03baacbfb32be2a on avdi:master.

avdi commented 11 years ago

Thanks for this, this is really helpful. Do you mind making the inline-noted changes?

coveralls commented 11 years ago

Coverage remained the same when pulling a49f5b70765acb8f20958bf394f331d39344cd97 on samnang:move_builder_methods_into_commands into 0869d4a8d4b304ae18e68789d03baacbfb32be2a on avdi:master.

coveralls commented 11 years ago

Coverage remained the same when pulling 2dc6e30a13894b2e2b3d5bbec0d3d632c52d2cd3 on samnang:move_builder_methods_into_commands into 0869d4a8d4b304ae18e68789d03baacbfb32be2a on avdi:master.

samnang commented 11 years ago

Done for changes. Do you have other things to me to look at before merging this?

avdi commented 11 years ago

You are awesome.