Add "pebble" mode - Githubissues

avdi / naught

A toolkit for building Null Object classes in Ruby

MIT License

1.05k stars 53 forks source link

Add "pebble" mode #35

Closed gvc closed 11 years ago

gvc commented 11 years ago

Closes #29.

coveralls commented 11 years ago

Coverage remained the same when pulling 16fde1a409ee674e1d1011aa6cfb7ee95a65ba04 on gvc:add_pebble_object into 0869d4a8d4b304ae18e68789d03baacbfb32be2a on avdi:master.

avdi commented 11 years ago

This makes me happy!

2 things, if you don't mind:

Make it into a command object instead of method on the builder.
I'm not a big fan of putting expectations on Kernel in tests. I'm also not sure why we need p here instead of puts, since we don't need to inspect the interpolated string. Can you update this to either a) capture stdout and test the captured tests; or b) optionally dependency-inject an "out" role and use that role to do the output? If you're not clear on how to do these I can take a crack at it.

Thanks!

gvc commented 11 years ago

Great @avdi, thank you for your input. I'll try and tackle these questions this week. If I get stuck somewhere I'll let you know!

coveralls commented 11 years ago

Coverage remained the same when pulling 8b615cb5916b7444cb942f38c0f26092022317a1 on gvc:add_pebble_object into 0869d4a8d4b304ae18e68789d03baacbfb32be2a on avdi:master.

coveralls commented 11 years ago

Coverage remained the same when pulling b2c68a0502b059132cfe494ee5f840241204f413 on gvc:add_pebble_object into 0869d4a8d4b304ae18e68789d03baacbfb32be2a on avdi:master.

coveralls commented 11 years ago

Coverage remained the same when pulling 6ec840a7d2cb5fdb3b646532b23b82f392c1c3d9 on gvc:add_pebble_object into 0869d4a8d4b304ae18e68789d03baacbfb32be2a on avdi:master.

julianalucena commented 11 years ago

Hey, @avdi. Could you look at it again, please?

avdi commented 11 years ago

Rockin'!