search

avdwebLibraries / avdweb_Switch

Switch library with longPress and doubleClick
http://www.avdweb.nl/arduino/hardware-interfacing/simple-switch-debouncer.html
GNU General Public License v3.0
45 stars 16 forks source link

Arduino library name change to avdweb_Switch #5

Closed Martin-Laclaustra closed 6 years ago

Martin-Laclaustra commented 6 years ago

Change the name which is used in the Arduino libraries. This way the arduino library name is consistent with the include directive (avdweb_Switch)

Martin-Laclaustra commented 6 years ago

As the class is still named "Switch" this might not be appropriate. What are your thoughts about consistency across "names"? Why did you decide to change the filenames and library folder name? Will "Switch" potentially clash with some keyword/class of the Arduino or ESP cores?

avandalen commented 6 years ago

The library was called Switch some years ago and just recent I name all my libraries avdweb_blabla.

Martin-Laclaustra commented 6 years ago

@avandalen Dear Albert, I have been thinking that changing the name of the library and the files will break former projects that rely on this library, given that it has been published in the Arduino libraries list. I request your permission to revert back to the original name before preparing a release. I believe that you receive equal credit appearing as the author, and you lose little removing your initials from the: a) cpp and h file names b) library name (in the properties file) c) github repository Please let me know if you agree and your thoughts in this regard. Best regards!

avandalen commented 6 years ago

Hello Martin

I have been thinking that changing the name of the library and the files will break former projects that rely on this library, given that it has been published in the Arduino libraries list. yes this is true

Further you can do what you want.

An idea is to take the switch class as parent and make derived classes for other processors

best regards

Albert

From: Martin-Laclaustra Sent: Sunday, July 22, 2018 11:16 PM To: avandalen/avdweb_Switch Cc: Albert van Dalen ; Mention Subject: Re: [avandalen/avdweb_Switch] Arduino library name change to avdweb_Switch (#5)

@avandalen Dear Albert, I have been thinking that changing the name of the library and the files will break former projects that rely on this library, given that it has been published in the Arduino libraries list. I request your permission to revert back to the original name before preparing a release. I believe that you receive equal credit appearing as the author, and you lose little removing your initials from the: a) cpp and h file names b) library name (in the properties file) c) github repository Please let me know if you agree and your thoughts in this regard. Best regards!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.