avelino / awesome-go

A curated list of awesome Go frameworks, libraries and software
https://awesome-go.com
MIT License
133.53k stars 11.95k forks source link

add sqlp2 #5213

Closed valord577 closed 6 months ago

valord577 commented 9 months ago

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

Note: that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below that apply before you submit PR. Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

Thanks for your PR, you're awesome! :+1:

github-actions[bot] commented 9 months ago

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

Your project is under review. It may take a few days to be approved.

cassiobotaro commented 9 months ago

@valord577 The project does not meet our quality standards. Could you take a look?

be thoroughly documented (README, pkg.go.dev doc comments, etc.) in the English language, so everyone is able to understand the project's intention and how it works. All public functions and types should have a Go-style documentation header;

valord577 commented 9 months ago

@cassiobotaro

Now I've added the documentation for the public functions.

Previously goreportcard would detect the documentation of a function.

I'am so sorry. Now it doesn't detect it, so it's ignored by me.

cassiobotaro commented 9 months ago

@valord577 Sorry, but I am still missing more docs, examples, etc. Don't look like an awesome go library.

valord577 commented 8 months ago

@cassiobotaro Would you mean https://github.com/valord577/sqlp2/tree/main/example?

I wrote in the readme at https://github.com/valord577/sqlp2?tab=readme-ov-file#example

John12da commented 8 months ago

Hello