avelino / awesome-go

A curated list of awesome Go frameworks, libraries and software
https://awesome-go.com
MIT License
128.64k stars 11.78k forks source link

ronykit added #5359

Open ehsannm opened 1 month ago

ehsannm commented 1 month ago

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

Please provide some links to your package to ease the review

Pull Request content

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

Thanks for your PR, you're awesome! :sunglasses:

github-actions[bot] commented 1 month ago

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

Your project is under review. It may take a few days to be approved.

yassinebenaid commented 1 month ago
  1. The coverage service link (eg. codecov) is missing.
  2. goreportcard.com link doesn't look to be working.

please read contributing guide

yassinebenaid commented 1 month ago

Edit 22/24:

Screenshot 2024-07-22 at 10 20 35

Code coverage is low. Some packages (eg. rony) aren't event covered by tests (0%).

ehsannm commented 1 month ago

You are correct about the unit tests. However, the testenv package is used for integration tests. The rony package serves as a wrapper around other packages. Ronykit is a modular framework that allows us to add packages and customize its functionality. The 'std' packages are reference implementations. We plan to add more unit tests in the future, but the system is already in production, stable, and performs well.

TechEmpower Benchmarks