avelino / awesome-go

A curated list of awesome Go frameworks, libraries and software
https://awesome-go.com
MIT License
133.28k stars 11.94k forks source link

Add keilerkonzept/topk #5408

Closed sgreben closed 1 month ago

sgreben commented 2 months ago

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

Please provide some links to your package to ease the review

Pull Request content

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

Thanks for your PR, you're awesome! :sunglasses:

github-actions[bot] commented 2 months ago

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

Your project is under review. It may take a few days to be approved.

sgreben commented 1 month ago

In terms of relevance for inclusion:

The only other high-quality top-k sketch package for Go - https://github.com/segmentio/topk - does not implement the sliding-window variant of HeavyKeeper (while keilerkonzept/topk does).

Currently, segmentio/topk is not being maintained (see the note in their repo). As a result, it's missing a few optimizations and so the non-sliding sketch in keilerkonzept/topk is also generally faster than the one in segmentio/topk.

sgreben commented 1 month ago

the actual link in the README.md was missing the URI scheme 😅 Here's a follow-up PR #5417 with the fix..