avelino / awesome-go

A curated list of awesome Go frameworks, libraries and software
https://awesome-go.com
MIT License
133.28k stars 11.94k forks source link

Add workflow frameworks and github.com/luno/workflow #5477

Closed andrewwormald closed 2 weeks ago

andrewwormald commented 2 weeks ago

We want to ensure high quality of the packages. Make sure that you've checked the boxes below before sending a pull request.

Not every repository (project) will require every option, but most projects should. Check the Contribution Guidelines for details.

Please provide some links to your package to ease the review

Pull Request content

Category quality

Note that new categories can be added only when there are 3 packages or more.

Packages added a long time ago might not meet the current guidelines anymore. It would be very helpful if you could check 3-5 packages above and below your submission to ensure that they also still meet the Quality Standards.

Please delete one of the following lines:

https://github.com/albrow/jobs - archived

Thanks for your PR, you're awesome! :sunglasses:

github-actions[bot] commented 2 weeks ago

Thank you for contributing to awesome-go. We will review your contribution as soon as possible.

Make sure you add the links in the body of the pull request that are requested in the contribution guide:

Your project is under review. It may take a few days to be approved.

yassinebenaid commented 2 weeks ago

You mentioned that you've removed: https://github.com/albrow/jobs. I think you forget to remove it as it doesn't show up as removed in your changes.

andrewwormald commented 2 weeks ago
  1. You have added a new category, make sure you list it upon categories list.
  2. Make sure the category is in the right order, Workflow cannot come before JSON. the same goes for categories list on top of the README.
  3. You mentioned that you've removed the https://github.com/albrow/jobs, it doesn't seem to be removed in your changes.

Thanks @yassinebenaid, will make the appropriate changes.

andrewwormald commented 2 weeks ago

@yassinebenaid found the removal of https://github.com/albrow/jobs in a unpushed commit. Should be all good now.

andrewwormald commented 2 weeks ago

Brilliant - thank you