avelino / awesome-go

A curated list of awesome Go frameworks, libraries and software
https://awesome-go.com
MIT License
133.83k stars 11.95k forks source link

PULL_REQUEST_TEMPLATE file #855

Closed matrixik closed 8 years ago

matrixik commented 8 years ago

I would like to add file PULL_REQUEST_TEMPLATE to repo:

Please check if what you want to add to `awesome-go` list meets 
[quality standards](https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#quality-standard) 
before sending pull request. Thanks!

Link to https://goreportcard.com/: <>

Link to https://gocover.io/: <>

Objections, comments? @avelino @shurcooL

dmitshur commented 8 years ago

No objections from me, that looks good.

Minor, but maybe make the first paragraph into a single sentence. Right now, it would render oddly across 3 lines:

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

matrixik commented 8 years ago

Thank you for comment. When I tried it yesterday it was rendered in one line, it needed empty line between lines I wanted in separate lines (nice sentence ;) ). I will fix it if needed.

matrixik commented 8 years ago

I also thinking about adding as last line something like: If package have low scores inform maintainers or you could help them with PR. Or maybe you could propose some better sounding advice.

kirillDanshin commented 8 years ago

What do you think about adding something like this checklist and note below?


Note, that new categories can be added only when there are 3 packages or more.

Make shure that you've checked the boxes below before you submit PR:

Thanks for your PR, you're awesome :+1:


avelino commented 8 years ago

+1

kirillDanshin commented 8 years ago

Please, review my PR (#890).