avellinwong01 / pe

0 stars 0 forks source link

Workout on a future date can be added without scheduling command #13

Open avellinwong01 opened 2 years ago

avellinwong01 commented 2 years ago

image.png

Such workouts do not appear under the list of scheduled workouts for the future, which seems counterintuitive. Instead, they appear under "completed workouts" which doesn't really make sense.

image.png

image.png

soc-pe-bot commented 2 years ago

Team's Response

add workout is to record workouts(mainly completed ones), with the calories burned.

add schedule is simply to plan/schedule workouts, having an idea of your workout plan in the future.

Although not the conventional usage, add workout retains the ability to record workouts in the future as some users might find some use for it. For example, some users might know they are doing a workout the next morning, they would find it useful to record a workout(with its calories) in advance, they know they will be doing in case they forget to record it.

Basically this is an implementation choice since it allows for user flexibility IF they want to record stuff in advance.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: With the functionalities of the 2 commands overlapping, I find this to be very confusing for the user. Would it not be better to just then have only 1 workout command that can add both past and future workouts? Then have a function to mark a workout as completed, because sometimes even if users add a workout to the future he may eventually not do it (hence the calories don't count). Else if schedule workouts is meant to be for future workouts, the regular add workout command (which requires the user to input calories burned, is to record workouts that are completed so as to count calories) should not be allowed to add future workouts right? Then similarly have a function to make a workout from the list of schedule workouts as completed on the day that the workout was scheduled.


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: The implementation is honestly quite confusing for me due to the overlapping command usage (and needing to handle 2 separate lists of workouts and schedule workouts yet without a clear distinction between the 2 commands). I believe this causes more than just a minor inconvenience that happens very rarely.