search

avendesora / pythonbible

A python library for validating, parsing, normalizing scripture references and retrieving scripture texts (for open source and public domain versions)
https://docs.python.bible
MIT License
58 stars 11 forks source link

Roman Numeral Chapter Numbers #1

Closed avendesora closed 4 years ago

avendesora commented 4 years ago

I was looking through a book of sermons and noticed that all of the chapter numbers in the scripture references where Roman numerals. In the interest of being able to easily parse scanned text for scripture references, we probably ought to update our regular expressions to find references with chapter numbers in Roman numeral form and update the normalize function to convert it into the appropriate integer value.

These references also do not contain the colon (probably since it is unnecessary with the chapter numbers and verse numbers being in a different format) but rather a period.

For example:

Matthew xvii. 19-21 Isa. iii. 10, 11 Jeremiah xlviii. 11, 12 1 John v. 10 2 Kings vii. 2

avendesora commented 4 years ago

should be fixed now with this commit:

https://github.com/avendesora/python-bible/commit/346cb83a387279b205b6656b907345074ac019af