Primarily, I added 2 new public domain versions to the pythonbible:
World English Bible - this version has some extra verses occasionally, like Romans 14:24-26, due to reliance on different manuscripts, but is regarded as a modern reputable translation
Berean Standard Bible - this version was published in 2022, and is highly esteemed, using the best manuscripts with and emphasis on matching the Hebrew and Greek words carefully. Honestly, considering this and the modern language, I think this BSB could be set as the DEFAULT_VERSION for pythonbible, but that's just my opinion
Secondarily, I included a simple example for new developers and users to be able to quickly understand how this package can be used.
examples/print_verses.py
Please include a summary of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies that are required for this change.
[x] I have added tests that prove my fix is effective or that my feature works.
[X] I have run pre-commit locally prior to submission and fixed any errors/warnings.
In the bibles under pythonbible/bible/bsb and pythonbible/bible/web
There were many errors during the ruff tests related to formatting: lines being too long and the presence of right and left quote characters, and "Boolean positional value in function call" which I think could be ignored?
examples/print_verses.py
examples/print_verses.py:5:1: ERA001 Found commented-out code
examples/print_verses.py:6:1: ERA001 Found commented-out code
examples/print_verses.py:7:1: ERA001 Found commented-out code
examples/print_verses.py:8:1: ERA001 Found commented-out code
examples/print_verses.py:16:1: T201 print found
examples/print_verses.py:19:5: T201 print found
examples/print_verses.py:20:89: E501 Line too long (189 > 88)
examples/print_verses.py:24:9: T201 print found
[X] I have run tests locally prior to submission and they are passing.
The new examples/print_verses.py served as a functional test, and it was working for both BSB and WEB
[ ] I have added necessary documentation (if appropriate).
[ ] I have updated the README (if appropriate).
[ ] I have updated the CHANGELOG (if appropriate).
[ ] I have updated the version number (if appropriate).
[ ] I have updated the requirements (if appropriate).
Tips
- Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request.
- Continue your discussion with Sourcery by replying directly to review comments.
- You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai):
- Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
- Change the review language;
- You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
Description
Primarily, I added 2 new public domain versions to the
pythonbible
:pythonbible
, but that's just my opinionSecondarily, I included a simple example for new developers and users to be able to quickly understand how this package can be used.
examples/print_verses.py
Please include a summary of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies that are required for this change.
Checklist:
pythonbible/bible/bsb
andpythonbible/bible/web
examples/print_verses.py
print
foundprint
foundprint
foundexamples/print_verses.py
served as a functional test, and it was working for both BSB and WEB