avendesora / pythonbible

A python library for validating, parsing, normalizing scripture references and retrieving scripture texts (for open source and public domain versions)
https://docs.python.bible
MIT License
58 stars 11 forks source link

updating develop with the latest hotfixes in main #34

Closed avendesora closed 3 years ago

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.16%.

Quality metrics Before After Change
Complexity 4.32 ⭐ 4.32 ⭐ 0.00
Method Length 58.32 ⭐ 57.63 ⭐ -0.69 👍
Working memory 8.83 🙂 8.80 🙂 -0.03 👍
Quality 75.40% 75.56% 0.16% 👍
Other metrics Before After Change
Lines 2501 2501 0
Changed files Quality Before Quality After Quality Change
pythonbible/init.py 82.94% ⭐ 82.94% ⭐ 0.00%
pythonbible/formatter.py 73.69% 🙂 73.88% 🙂 0.19% 👍
pythonbible/verses.py 81.74% ⭐ 82.03% ⭐ 0.29% 👍
pythonbible/bible/osis/parser.py 69.19% 🙂 69.39% 🙂 0.20% 👍
tests/test_formatter.py 86.95% ⭐ 86.95% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pythonbible/formatter.py format_scripture_text_verse_by_verse 13 🙂 112 🙂 15 😞 47.15% 😞 Extract out complex expressions
pythonbible/bible/osis/parser.py _handle_child_element 12 🙂 116 🙂 12 😞 51.75% 🙂 Extract out complex expressions
pythonbible/bible/osis/parser.py _handle_verse_tag 10 🙂 109 🙂 12 😞 54.45% 🙂 Extract out complex expressions
pythonbible/formatter.py format_single_reference 10 🙂 100 🙂 12 😞 55.66% 🙂 Extract out complex expressions
pythonbible/bible/osis/parser.py _get_paragraphs 2 ⭐ 119 🙂 14 😞 57.90% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.