search

avendesora / pythonbible

A python library for validating, parsing, normalizing scripture references and retrieving scripture texts (for open source and public domain versions)
https://docs.python.bible
MIT License
60 stars 12 forks source link

50 OSIS Parser is ignoring the seg and divineName tags (Sourcery refactored) #52

Closed sourcery-ai[bot] closed 2 years ago

sourcery-ai[bot] commented 2 years ago

Pull Request #51 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the hotfix/50_osis_parser_is_ignoring_the_seg_and_divinename_tags branch, then run:

git fetch origin sourcery/hotfix/50_osis_parser_is_ignoring_the_seg_and_divinename_tags
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 5.02 ⭐ 5.02 ⭐ 0.00
Method Length 45.16 ⭐ 45.05 ⭐ -0.11 👍
Working memory 8.17 🙂 8.17 🙂 0.00
Quality 72.09% 🙂 72.11% 🙂 0.02% 👍
Other metrics Before After Change
Lines 342 340 -2
Changed files Quality Before Quality After Quality Change
pythonbible/bible/osis/parser.py 72.09% 🙂 72.11% 🙂 0.02% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pythonbible/bible/osis/parser.py _handle_child_element 12 🙂 127 😞 11 😞 52.12% 🙂 Try splitting into smaller methods. Extract out complex expressions
pythonbible/bible/osis/parser.py _handle_verse_tag 10 🙂 109 🙂 11 😞 56.19% 🙂 Extract out complex expressions
pythonbible/bible/osis/parser.py _get_paragraphs 2 ⭐ 116 🙂 11 😞 62.99% 🙂 Extract out complex expressions
pythonbible/bible/osis/parser.py _get_paragraph_from_element 6 ⭐ 77 🙂 10 😞 66.36% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!