search

avendesora / pythonbible

A python library for validating, parsing, normalizing scripture references and retrieving scripture texts (for open source and public domain versions)
https://docs.python.bible
MIT License
58 stars 11 forks source link

default BookTitles, improved test coverage #68

Closed avendesora closed 2 years ago

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.41%.

Quality metrics Before After Change
Complexity 6.01 ⭐ 5.59 ⭐ -0.42 👍
Method Length 59.08 ⭐ 59.19 ⭐ 0.11 👎
Working memory 7.35 🙂 7.33 🙂 -0.02 👍
Quality 73.29% 🙂 73.70% 🙂 0.41% 👍
Other metrics Before After Change
Lines 532 522 -10
Changed files Quality Before Quality After Quality Change
pythonbible/formatter.py 73.29% 🙂 73.70% 🙂 0.41% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
pythonbible/formatter.py _format_scripture_text_verse_by_verse 9 🙂 116 🙂 15 😞 50.22% 🙂 Extract out complex expressions
pythonbible/formatter.py format_single_reference 9 🙂 111 🙂 11 😞 56.85% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!